-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support embulk util retryhelper jetty version 94 #76
Support embulk util retryhelper jetty version 94 #76
Conversation
…etryhelper-jetty94.
….util.retryhelper.jetty94
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ah, one thing. Please update this part as well. embulk-output-elasticsearch/NOTICE_GEM Lines 13 to 14 in 65ad90c
|
Hi @dmikurube , I have updated NOTICE_GEM and CHANGELOG.md. Thank you |
Hi @dmikurube , Please help me to approve workflows. Regards, |
Approve which workflows? |
Hi @dmikurube , Sorry for late response, as the document: https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks
As, I checked the workflow has been run: So, you can ignore my previous comment. |
Hi @dmikurube , Please help me merge & release this PR. Thank you, |
Other pull requests are merged. It's time to go. Thanks for working on it! |
Which issue this PR resolve for?
The new JVM uses TLS 1.3 as default, but Jetty 92 and Jetty 93 don’t support TLS 1.3.
How this PR resolve this issue?
From
To
There was the same PR, we did before:
embulk/embulk-util-retryhelper#11