Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EMBR-5747] Adding url ignore list to URLSessionCaptureService #134

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

NachoEmbrace
Copy link
Contributor

Can be configured through the string array URLSessionCaptureService.Options.ignoredURLs.
Any request pointing to an URL that contains any of the strings in that array will be ignored by the service.

@NachoEmbrace NachoEmbrace requested a review from a team as a code owner December 3, 2024 17:08
Copy link

github-actions bot commented Dec 3, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link

github-actions bot commented Dec 3, 2024

Warnings
⚠️ No CHANGELOG entry added.
⚠️

Sources/EmbraceCore/Capture/Network/URLSessionCaptureService+Options.swift#L22 - Line should be 120 characters or less; currently it has 128 characters (line_length)

⚠️

Sources/EmbraceCore/Capture/Network/URLSessionCaptureService.swift#L64 - TODOs should be resolved (See what to do when this kind ...) (todo)

⚠️

Sources/EmbraceCore/Capture/Network/URLSessionTaskHandler.swift#L227 - where clauses are preferred over a single if inside a for (for_where)

⚠️

Tests/EmbraceCoreTests/Capture/Network/DefaultURLSessionTaskHandlerTests.swift#L199 - Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)

⚠️

Tests/EmbraceIOTests/CaptureServiceBuilderTests.swift#L49 - Line should be 120 characters or less; currently it has 124 characters (line_length)

⚠️

Tests/EmbraceIOTests/CaptureServiceBuilderTests.swift#L120 - Line should be 120 characters or less; currently it has 124 characters (line_length)

⚠️

Tests/EmbraceIOTests/CaptureServiceBuilderTests.swift#L137 - Line should be 120 characters or less; currently it has 124 characters (line_length)

Generated by 🚫 Danger Swift against 79ad515

@NachoEmbrace NachoEmbrace merged commit 4126927 into main Dec 4, 2024
6 of 8 checks passed
@NachoEmbrace NachoEmbrace deleted the network_capture_ignored_urls branch December 4, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants