Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating markAsKeySpan() #124

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Deprecating markAsKeySpan() #124

merged 1 commit into from
Nov 26, 2024

Conversation

NachoEmbrace
Copy link
Contributor

No description provided.

@NachoEmbrace NachoEmbrace requested a review from a team as a code owner November 12, 2024 18:34
Copy link

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link

Fails
🚫

Examples/BrandGame/BrandGame/View/Menu/Minigames/Reflex/ReflexGameModel.swift#L32 - There must not be any space between access control modifier and scope (attribute_name_spacing)

🚫

Examples/BrandGame/BrandGame/View/Menu/Minigames/Reflex/ReflexGameModel.swift#L35 - There must not be any space between access control modifier and scope (attribute_name_spacing)

🚫

Examples/BrandGame/BrandGame/View/Menu/Minigames/Reflex/ReflexGameModel.swift#L38 - There must not be any space between access control modifier and scope (attribute_name_spacing)

Warnings
⚠️ Please provide a description for the changes in this Pull Request.
⚠️ No CHANGELOG entry added.
⚠️ No tests added / modified.
⚠️

Sources/EmbraceOTelInternal/Trace/EmbraceSemantics/Span/Span+Embrace.swift#L13 - TODOs should be resolved (Remove in next major version) (todo)

⚠️

Sources/EmbraceOTelInternal/Trace/EmbraceSemantics/SpanBuilder/SpanBuilder+Embrace.swift#L21 - TODOs should be resolved (Remove in next major version) (todo)

Generated by 🚫 Danger Swift against 8756edf

@NachoEmbrace NachoEmbrace merged commit 321745b into main Nov 26, 2024
5 of 8 checks passed
@NachoEmbrace NachoEmbrace deleted the deprecate_key_span branch November 26, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants