Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump OpenTelemetry to new version #123

Closed
wants to merge 1 commit into from
Closed

Conversation

ArielDemarco
Copy link
Collaborator

Overview

This issue led to the creation of a fix in OpenTelemetrySdk. This PR uses that specific commit/revision as a dependency until a new version of OTel is released.

Additionally, we modified the build_dependencies script to support building dependencies from revisions, branches, and versions extracted from Package.resolved.

Fixes #116

@ArielDemarco ArielDemarco requested a review from a team as a code owner November 8, 2024 22:25
Copy link

github-actions bot commented Nov 8, 2024

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 1 package(s) with unknown licenses.
See the Details below.

License Issues

Package.resolved

PackageVersionLicenseIssue Type
github.com/open-telemetry/opentelemetry-swift>= 0NullUnknown License

OpenSSF Scorecard

PackageVersionScoreDetails
swift/github.com/open-telemetry/opentelemetry-swift >= 0 UnknownUnknown

Scanned Files

  • Package.resolved

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.95%. Comparing base (a7acf84) to head (32b361c).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #123   +/-   ##
=======================================
  Coverage   91.94%   91.95%           
=======================================
  Files         410      410           
  Lines       26604    26604           
=======================================
+ Hits        24462    24464    +2     
+ Misses       2142     2140    -2     

see 2 files with indirect coverage changes

---- 🚨 Try these New Features:

@ArielDemarco
Copy link
Collaborator Author

Closing this PR as this one uses an official version of OTel.
Will pick up the changes in the build_dependencies script and create another PR with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document potential crashes when using SDK methods from background threads
1 participant