Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing network payload rules parsing #122

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

NachoEmbrace
Copy link
Contributor

It seems that the remote config API was never updated with the suggested changes for network payload capture.
This resulted in network capture rules not being parsed correctly on this version of the SDK.

This PR contains the necessary changes for us to parse the old payload.

@NachoEmbrace NachoEmbrace requested a review from a team as a code owner November 8, 2024 15:32
Copy link

github-actions bot commented Nov 8, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link

github-actions bot commented Nov 8, 2024

Warnings
⚠️ No CHANGELOG entry added.

Generated by 🚫 Danger Swift against 494222d

Copy link
Collaborator

@ArielDemarco ArielDemarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering the actual API wasn't updated... is there any value that were considering that could arrive to the SDK and we don't know how to handle? (the only one I remember is the status_code -1, but I think we handle that one)

@NachoEmbrace
Copy link
Contributor Author

NachoEmbrace commented Nov 8, 2024

Considering the actual API wasn't updated... is there any value that were considering that could arrive to the SDK and we don't know how to handle? (the only one I remember is the status_code -1, but I think we handle that one)

The only big difference was the http method being a single string instead of an array and the expiration being the time until the rule expires instead of the expiration timestamp.
On top of that some keys have different names.

Other than that there are keys that could be present but will be ignored. Overall there should be no issues.

@NachoEmbrace NachoEmbrace merged commit 27ea47c into main Nov 11, 2024
6 of 8 checks passed
@NachoEmbrace NachoEmbrace deleted the fix_network_capture_payload_parse branch November 11, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants