Fix vite app via fixin' deps #9621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
commented
Dec 18, 2024
There was a problem hiding this comment.
without the changes there are types-squigglies in the app
NullVoxPopuli
commented
Dec 18, 2024
| @@ -144,7 +144,6 @@ | |||
| }, | |||
| "overrides": { | |||
| "ember-auto-import": "^2.10.0", | |||
| "@embroider/macros": "^1.16.6", | |||
There was a problem hiding this comment.
without this change the wrong version of macros ends up being used (along with the wrong shared-internals, etc)
NullVoxPopuli
commented
Dec 18, 2024
| @@ -119,7 +119,7 @@ | |||
| "ember-load-initializers": "^3.0.1", | |||
| "ember-modifier": "^4.2.0", | |||
| "ember-page-title": "^8.2.3", | |||
| "ember-qunit": "8.0.2", | |||
There was a problem hiding this comment.
v8 used AMD to load tests via the TestLoader
runspired
added a commit
that referenced
this pull request
Dec 19, 2024
* port config tooling from main * port patches from main * port vscode settings from main * replace all root config files with versions from main * delete current individual configs that may not match main * port all configs for adapter and -ember-data from main * port build-config and core-types from main * update github workflows to match main * add 4.12 config to ember-try * port script and release changes from main * port release instructions from main * port @types changes from main * port internal tooling packages from main * move -ember-data source-code from addon to src directory * update tracking package with configs from main * fix peer version in tracking package * port config changes from main to store package * update serializer configs from main * port all request-utils changes and configs from main. update deprecation available versions * update available deprecations * port code changes and configs for request package from main * fix version of internal-config package * update model configs to match main * update legacy-compat configs to match main * port configs from main for json-api package * update graph with configs from main * update debug package to exactly match main * port active-record and rest builders from main * copy json-api builder source-code from main * rename adapter-encapsulation ember-data__adapter test suite and update configs * port tests for builders from main * port changes to docs test app from main, will require updating fixtures later * update blueprint tests for 4.12, will require fixing blueprints for 4.12 * remove debug-encapsulation test-app (defunct) * port graph tests from main to replace current tests, will require implementing diffing or removing diff tests * update embroider, fastboot, perf, size test-apps from main * update json-api tests to match main * port model package tests from main * port request package tests from main * port serializer package tests from main * update main test-app configs from main branch * update configs for uneeded packages * fixup versions * fixup root package json * port diagnostic and holodeck from main * new lockfile :) * update build-config imports * run lint:prettier:fix * fixup deprecation booleans * yolo run lint:fix * update eslint config * get request pkg types building * update graph package source-code and types * update deprecations list * update types and cache source-code in json-api package * update tracking impl with source-code from main * port vite test-app from main * chore update types etc for ember-data package * fix lockfile * port source-code and type changes to legacy-compat while preserving deprecations. opted to eliminate the deprecated codepaths for v1 cache as ember-m3 and model-fragments will both never reach this version for their own support purposes * remove deprecations we have opted to eliminate * update source-code, types and blueprints for @ember-data/model from main * update deprecation flags * port source-code, types for store package * fixup deprecation config, fix deprecations in legacy-compat and model * fixup ember-data blueprints * fixup adatper code and blueprints * fixup vite config for store * fix build config for model * update serializer package to match main * fix some type issues in model * fixup all the types * get request tests passing * fixup tests for docs * fix model tests * update main test app * fixup prettier * add reactivity utils * update all /acceptance and /deprecations tests * Check that the main/tests/unit/utils and top-level are in-sync with main (#9600) * Check that the main/tests/unit/utils and top-level are in-sync with main * Undelete test in adapter-errors-test * update integration/adapter tests (#9602) * Sync main/tests/unit/{system,store} w/ main (#9601) * Update main/tests/unit/system * Update tests/main/tests/unit/store * update integration/{backwards-compat,cache-handler,cache,emergent-beh… (#9603) update integration/{backwards-compat,cache-handler,cache,emergent-behavior,identifiers} * update integration/{legacy-compat,record-arrays,record-data} (#9604) * More unit sync nvp (#9605) * Sync tests/main/tests/unit/record-arrays/record-array-test.js * Sync tests/main/tests/unit/record-arrays/adapter-populated-record-array-test.js * Get through most of unit/model * Legacy compat tests + finish unit/model folder (#9606) * Finish the models folder * Add legacy-compat tests * custom class model * update integration/records tests (#9607) update integration/records * more tests for v4 (#9609) * update tests/integration/references * fix easier to fix integration/relationships tests * update tests/integration/{serializers,store} * fix tests in integration (no subdir) * finish off unit tests (adapters, custom-class-support) * update more integration tests * all the tests migrated * fix schema-record usage * downlevel ember-qunit to fix types * fixup types * fixup all the stuffs * cleanup deprecation triggers * for tests too' * enhance babel plugin * inline macro config for deprecation boolean * fix comment detection * fix lockfile and peer injection * setup graph package to handle 6.x deprecations * fix CI checks for v4-main * fix docs * fix missing vite command * fix app re-export * stash * update logging * fix some more tests etc. * get most the tests working * fix coerceid deprecation * more test fixes * all tests pass? * fix docs tests * fix typechecks * fixup try and cli etc. * fix lint * fix build transform * fixup lock * Fix vite app via fixin' deps (#9621) * Fix tsconfig.json for the vite app * Remove @embroider/macros from the overrides list in the root package.json * Upgrade to latest ember-qunit --------- Co-authored-by: NullVoxPopuli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Notes for the release