Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the paths in the canary tsconfig example #9542

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

Windvis
Copy link
Contributor

@Windvis Windvis commented Sep 30, 2024

Without the ./node_modules/ prefix, TS can't find the types. This is also what the warp-drive retrofit command does:

const fullTypePath = `./node_modules/${pkgName}/${typePath}`;

Related to the changes in ember-cli/ember-cli#10507

Without the `./node_modules/` prefix, TS can't find the types.
@Baltazore Baltazore added 🎯 canary PR is targeting canary (default) 🏷️ doc This PR adds/improves/or fixes documentation labels Oct 4, 2024
@runspired runspired merged commit 25832ac into emberjs:main Oct 10, 2024
20 of 24 checks passed
@Windvis Windvis deleted the patch-1 branch October 10, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 canary PR is targeting canary (default) 🏷️ doc This PR adds/improves/or fixes documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants