fix error documents

emberjs · Jul 11, 2024 · b4c319d · b4c319d
1 parent 84195b9
commit b4c319d
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/packages/store/src/-private/cache-handler/handler.ts b/packages/store/src/-private/cache-handler/handler.ts
@@ -19,7 +19,6 @@ import type {
 import type { ApiError } from '@warp-drive/core-types/spec/error';
 import type { ResourceIdentifierObject } from '@warp-drive/core-types/spec/json-api-raw';
 
-import type { OpaqueRecordInstance } from '../../-types/q/record-instance';
 import { Document } from '../document';
 import type { Store } from '../store-service';
 import {
@@ -246,11 +245,11 @@ function maybeUpdateErrorUiObjects<T>(
 ): ResourceErrorDocument {
   const { identifier } = options;
 
-  assert(`Expected an error document`, isErrorDocument(document));
-
-  if (!identifier && !options.shouldHydrate) {
+  // TODO investigate why ResourceErrorDocument is insufficient for expressing all error types
+  if (!isErrorDocument(document) || (!identifier && !options.shouldHydrate)) {
     return document;
   }
+
   let doc: Document<T> | undefined;
   if (identifier) {
     doc = store._documentCache.get(identifier) as Document<T> | undefined;

diff --git a/packages/store/src/-private/cache-handler/utils.ts b/packages/store/src/-private/cache-handler/utils.ts
@@ -1,14 +1,15 @@
+import type { StableDocumentIdentifier } from '@warp-drive/core-types/identifier';
 import type {
   ImmutableCreateRequestOptions,
   ImmutableDeleteRequestOptions,
   ImmutableRequestInfo,
   ImmutableUpdateRequestOptions,
   StructuredDataDocument,
 } from '@warp-drive/core-types/request';
-import type { Store } from '../store-service';
-import type { StableDocumentIdentifier } from '@warp-drive/core-types/identifier';
-import type { ApiError } from '@warp-drive/core-types/spec/error';
 import type { ResourceDataDocument, ResourceErrorDocument } from '@warp-drive/core-types/spec/document';
+import type { ApiError } from '@warp-drive/core-types/spec/error';
+
+import type { Store } from '../store-service';
 
 export const MUTATION_OPS = new Set(['createRecord', 'updateRecord', 'deleteRecord']);
 

diff --git a/packages/store/src/-private/store-service.ts b/packages/store/src/-private/store-service.ts
@@ -40,6 +40,7 @@ import type { OpaqueRecordInstance } from '../-types/q/record-instance';
 import type { SchemaService } from '../-types/q/schema-service';
 import type { FindAllOptions, FindRecordOptions, LegacyResourceQuery, QueryOptions } from '../-types/q/store';
 import type { StoreRequestInput } from './cache-handler/handler';
+import type { CachePolicy } from './cache-handler/types';
 import { IdentifierCache } from './caches/identifier-cache';
 import {
   InstanceCache,
@@ -60,7 +61,6 @@ import type { Collection, IdentifierArray } from './record-arrays/identifier-arr
 import { coerceId, ensureStringId } from './utils/coerce-id';
 import { constructResource } from './utils/construct-resource';
 import { normalizeModelName } from './utils/normalize-model-name';
-import type { CachePolicy } from './cache-handler/types';
 
 export { storeFor };