Fix @ember/string dependency #1582
Conversation
|
@anehx should it be a peerDep? |
|
@RobbieTheWagner I don't think so. This addon is mostly used in other addons which do not include |
|
I think we should probably make it a peerDep and allow v3 and v4 like this https://github.com/minutebase/ember-can/blob/master/ember-can/package.json#L129 |
anehx
force-pushed
the
fix-string-dependency
branch
from
2ea5da3 to
a0aa434
Compare
|
@RobbieTheWagner Fair enough. I changed it in this PR. |
package.json
Outdated
| @@ -105,7 +105,6 @@ | |||
| "@babel/plugin-proposal-decorators": "^7.23.6", | |||
| "@babel/preset-env": "^7.23.6", | |||
| "@ember/optional-features": "^2.0.0", | |||
| "@ember/string": "^3.1.1", | |||
There was a problem hiding this comment.
This will still need to be a devDep too right, so we're installing it ourselves when running the test app etc?
There was a problem hiding this comment.
Absolutely, my bad. Fixed!
`@ember/string` must be a peer dpendency as `ember-cli-addon-docs` imports it in their codebase. Currently this still works, but with v4 of `@ember/string` (v2 addon) this will break as it fully relies on `ember-auto-import`.
anehx
force-pushed
the
fix-string-dependency
branch
from
a0aa434 to
e37a134
Compare
|
CI is failing for other reasons, so I will go ahead and merge this. Thanks for the PR! |
|
Hi, @RobbieTheWagner. Could you help release a patch version of The documentation site for |
|
@ijlee2 I would love to help release a new version, but CI is failing currently. If you have time to diagnose and fix those failures, we could definitely get a new version out. |
|
@RobbieTheWagner Ah, I didn't see the CI failing in the main branch. Since the error message refers to |
@ember/stringmust be a dependency asember-cli-addon-docsimports it in their codebase. Currently this still works, but with v4 of@ember/string(v2 addon) this will break as it fully relies onember-auto-import.