bugfix: hot-fix for blank pages on some routes

[bearcott]

as noted in #865 you get a blank page when visiting pages like:

• https://api.emberjs.com/ember/3.28/classes/Ember.Templates.components/methods/LinkTo?anchor=LinkTo
• http://api.emberjs.com/ember/release/classes/Ember.Templates.components/methods/Input

The immediate cause for the bug is the "Edit on Github" button breaking the page:

From my findings something is causing these page to render twice, the first time model.project.id is undefined for some reason. This causes the latest version check in the conditional to break. Imo avoiding this initial render would be the optimal fix so if anyone has an idea whats causing it that would be good!

For now I suggest a hot fix to check if model.project.id exists before rendering the component as well as model.file and model.line since they are also undefined for some reason. The component shouldn't be rendered anyways if any of these are undefined since it will just be a dead link.

[jenweber]

Thank you for the hotfix! That is very odd. We recently did some version updates and I’m guessing a bug got introduced. I’ll do a click test and deploy.

[jenweber]

@mansona I am wondering if we broke something at the 3.28 upgrade or in https://github.com/ember-learn/ember-api-docs/pull/862/files? Or possibly this was an earlier issue.

[jenweber]

Actually I'll have to wait a day or so to deploy. Heroku had some service problems today, and things still seem shaky. If any fellow learning team members want to merge and deploy to staging and then prod, after the Heroku issue clears up, that would be great. Instructions are in MAINTAINERS.md. I have click tested locally and this is good to go.

The Heroku Platform API is unavailable. Customers using the API, the CLI, and the Heroku Dashboard will be unable to make changes/releases to or queries of their applications. Applications currently running will continue to run. Engineers are investigating, we'll update as we have more details.

https://status.heroku.com/

[bearcott]

@jenweber thanks for the context. May I suggest possibly it's an API side issue? When I did some digging both the line and file references were undefined for Input I'm guessing may be related to deprecated builtins.

[jenweber]

@bearcott yeah I think you are on the right track, thinking that this probably has roots in the data. Unfortunately right now, the only way to change the underlying docs data is through running new releases of the libraries themselves (like ember-data) but we are working on a fix that will let us change things after the fact! So I will try to remember this case and look for it.