Skip to content

Commit

Permalink
include recommended ts-eslint rules for gts (#2107)
Browse files Browse the repository at this point in the history
* typescript recommended rules turn off eslint rules that do not work for ts/gts
but they only to that for known extensions, therefore we need to reapply them in our
recommended config
see issue typescript-eslint/typescript-eslint#8607

* copy rules
  • Loading branch information
patricklx authored Apr 2, 2024
1 parent 4ea4459 commit f5a5c01
Showing 1 changed file with 26 additions and 1 deletion.
27 changes: 26 additions & 1 deletion lib/config/recommended-gts.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,29 @@
const base = require('./base');
const gtsRules = require('../recommended-rules-gts');

module.exports = [...base, { rules: gtsRules }];
// see https://github.com/typescript-eslint/typescript-eslint/issues/8607
// https://github.com/typescript-eslint/typescript-eslint/blob/v7.4.0/packages/eslint-plugin/src/configs/eslint-recommended-raw.ts
const tsRecommended = {
'constructor-super': 'off', // ts(2335) & ts(2377)
'getter-return': 'off', // ts(2378)
'no-const-assign': 'off', // ts(2588)
'no-dupe-args': 'off', // ts(2300)
'no-dupe-class-members': 'off', // ts(2393) & ts(2300)
'no-dupe-keys': 'off', // ts(1117)
'no-func-assign': 'off', // ts(2630)
'no-import-assign': 'off', // ts(2632) & ts(2540)
'no-new-symbol': 'off', // ts(7009)
'no-obj-calls': 'off', // ts(2349)
'no-redeclare': 'off', // ts(2451)
'no-setter-return': 'off', // ts(2408)
'no-this-before-super': 'off', // ts(2376) & ts(17009)
'no-undef': 'off', // ts(2304) & ts(2552)
'no-unreachable': 'off', // ts(7027)
'no-unsafe-negation': 'off', // ts(2365) & ts(2322) & ts(2358)
'no-var': 'error', // ts transpiles let/const to var, so no need for vars any more
'prefer-const': 'error', // ts provides better types with const
'prefer-rest-params': 'error', // ts provides better types with rest args over arguments
'prefer-spread': 'error', // ts transpiles spread to apply, so no need for manual apply
};

module.exports = [...base, { rules: { ...gtsRules, ...tsRecommended } }];

0 comments on commit f5a5c01

Please sign in to comment.