Improve email forwarding #265
Conversation
TedGoas
added
the
bug
|
yep! i’ll take a look see how it plays out in my workflow. |
|
I will aim to take a look this week |
|
Why aren't all of the styles wrapped in I sent the raw HTML (hybrid template) to my gmail, and it worked as expected. I did the same test by sending the raw email to Outlook online, and then forwarding to EoA. The entire I believe the only real solution here is to inline all of the styles. We could add info to the README about that. For the sake of this repo, I can see why it makes sense to neatly organize many of the styles in the |
|
I'd like to avoid requiring an inline for email forwarding. Not everyone has access to an inliner (eg. emails coming from a codebase rather than an ESP) and requiring an inliner introduces a dependency, which goes against my core values for Cerberus. Would wrapping all the styles in a |
This PR attempts to improve Cerberus's rendering in Gmail after it's forwarded. #264 and #262 both report issues with the templates' rendering when forwarded. @maxackerman pointed out this nifty trick by Lee Munroe that prevents ESPs from inlining certain CSS properties, which seems to be the cause of the email breakage when forwarding.
I haven't fully tested this in Gmail, but adding it doesn't seem to cause any regression.
@maxackerman @marcelgruber would you be willing to help test this?