Geir/max allowed message size stored in client object #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The max allowed message size was already being parsed on the greeting but not stored and hence the client could not build logic on that. Now with this one can decide not to send if the message is larger than the max allowed size.
nifgraup
requested changes
Nov 11, 2022
src/client.js
Outdated
| @@ -70,6 +70,7 @@ class SmtpClient { | |||
| this._lastDataBytes = '' // Keep track of the last bytes to see how the terminating dot should be placed | |||
| this._envelope = null // Envelope object for tracking who is sending mail to whom | |||
| this._currentAction = null // Stores the function that should be run after a response has been received from the server | |||
| this._maxAllowedSize = 0 // Stores the max message size supported by the server as reported in the greeting | |||
There was a problem hiding this comment.
_ implies internal use but users of emailjs-imap-client will read this value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
max size of messages was being retrieved from server and logged out but not stored and hence not accessible in mail client before sending.