Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more explicit about waiting for the fetch process #73

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

snogge
Copy link
Collaborator

@snogge snogge commented Dec 17, 2024

Explicitly wait for the process returned by magit-fetch instead of relying on the magit-this-process variable.

Change magit-gerrit-view-patchset-diff and
magit-gerrit-download-patchset to use `with-temp-message' while
waiting for the gerrit process to complete.

Let the message functions do the format operation.
Still defaults to magit-this-process.
Explicitly tell magit-gerrit-process-wait which process to wait for.
@snogge
Copy link
Collaborator Author

snogge commented Dec 17, 2024

I'll leave this open for comments for a few days before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant