Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yaml/highlights.scm: Treat plain value with string face #196

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jlhg
Copy link

@jlhg jlhg commented Aug 17, 2023

The plain value (without quotes) in a YAML file is treated as a string. Therefore, its font face should match that of the quoted string

Original appearance:

圖片

After the fix, it looks like:

圖片

@meain
Copy link
Member

meain commented Aug 18, 2023

I think not highlighting it is how yaml-mode does it by default. Looking at neovim implementation, it seems to be the same as well. And so, I personally think we should leave it as is.

@jlhg
Copy link
Author

jlhg commented Aug 18, 2023

The plain text is highlighted by default in VS Code. However, I agree to leave it as it is if the package strictly follows the original design of yaml-mode.

圖片

圖片

@meain
Copy link
Member

meain commented Aug 21, 2023

I agree to leave it as it is if the package strictly follows the original design of yaml-mode.

The package AFAICT does not strictly follow the design of yaml-mode. That said, I personally don't think deviating from it brings us anything more in this specific case. I don't have any strong opinions on this. I'll leave it to @ubolonton on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants