Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add help extensions #168

Merged
merged 2 commits into from
Dec 22, 2020
Merged

Add help extensions #168

merged 2 commits into from
Dec 22, 2020

Conversation

pkryger
Copy link
Collaborator

@pkryger pkryger commented Dec 20, 2020

Add helpful and which-key as well as add C-c C-o keybinding in help-mode.

I've been using helpful for over 2 years now. I think they are both really useful, hence I took a liberty and enabled that by default.

Over the course of 2 years I've extended the setup a bit (like hooking up into helm, but not fully yet, due to a lack of support in helm-descbinds.

I really got to liking C-c C-o when working with magit and forge and I was missing this a lot when reading help for a function or a variable or a synopsis of some package (in package-list-packages).

Perhaps a window management could be improved so it doesn't clobber all available windows when digging deeper and deeper in a help links, but I leave it out for a time when I get to understanding how I really would like to use that. Perhaps, if you use it a bit you could come up with ideas how it should behave.

Copy link
Collaborator

@steve-downey steve-downey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been using which-key based on recommendation for lsp-mode, and it's very useful.

It looks like a few changes are hitchhiking in this PR, though?

modules/init-org.el Outdated Show resolved Hide resolved
modules/init-lib.el Outdated Show resolved Hide resolved
Add `helpful` and `which-key` as well as add `C-c C-o` keybinding in `help-mode`.
I've put it in a wrong section as well as used a wrong function.
Copy link
Collaborator

@steve-downey steve-downey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pkryger pkryger merged commit 0e89002 into emacs-exordium:master Dec 22, 2020
@pkryger pkryger deleted the helpful branch February 6, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants