Fix touch screen gestures (e.g., scrolling) for Emacs 30 #1948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emacs 30 introduces improved touch-screen support (via the Android port), see “Touchscreen Events” in the Emacs Lisp reference manual: By default, touch screen gestures are not processed when a command is bound to `down-mouse-1` (as `evil-mouse-drag-region` is), as that is taken as an indication that touch input should be translated to `down-mouse-1` followed by mouse motion events. This change applies the `ignored-mouse-command` property to `evil-mouse-drag-region` that is also present on `mouse-drag-region` in Emacs 30. This has the effect that touch screen gestures are prioritized and mouse events are only emitted when no gesture was detected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emacs 30 introduces improved touch-screen support (via the Android port), see “Touchscreen Events” in the Emacs Lisp reference manual: By default, touch screen gestures are not processed when a command is bound to
down-mouse-1(asevil-mouse-drag-regionis), as that is taken as an indication that touch input should be translated todown-mouse-1followed by mouse motion events.This change applies the
ignored-mouse-commandproperty toevil-mouse-drag-regionthat is also present onmouse-drag-regionin Emacs 30. This has the effect that touch screen gestures are prioritized and mouse events are only emitted when no gesture was detected.