Test/update incentive pool #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaeboklee-modo
commented
Jan 10, 2022
| )) as IncentivePool__factory; | ||
|
|
||
| newIncentivePool = await incentivePoolFactory.deploy( | ||
| deployer.address, |
There was a problem hiding this comment.
@donguks
When deploying new incentivePool, the moneyPool address in constructor argument should be set to the EOA account, like deployer
jaeboklee-modo
commented
Jan 10, 2022
| .connect(account0) | ||
| .deposit(elyfiContracts.underlyingAsset.address, account0.address, amount); | ||
|
|
||
| await elyfiContracts.moneyPool |
There was a problem hiding this comment.
@donguks
After initialize, execute updateIncentivePool in moneyPool contract to update new incentivePool. Args should be like below.
jaeboklee-modo
commented
Jan 10, 2022
| await elyfiContracts.moneyPool | ||
| .connect(deployer) | ||
| .updateIncentivePool(elyfiContracts.underlyingAsset.address, newIncentivePool.address); | ||
| const tx = await newIncentivePool |
There was a problem hiding this comment.
@donguks
After deploying, execute initializeIncentivePool in incentivePool contract to initialize pool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple test cases