Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Perpetual]: Update checksameassetposition function #576

Merged
merged 7 commits into from
Jun 19, 2024
Merged

[Perpetual]: Update checksameassetposition function #576

merged 7 commits into from
Jun 19, 2024

Conversation

amityadav0
Copy link
Contributor

Description

  • Load user data instead of traversing all the positions

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Deployment Notes

Are there any specific considerations to take into account when deploying these changes? This may include new dependencies, scripts that need to be executed, or any aspects that can only be evaluated in a deployed environment.

Screenshots and Videos

Please provide any relevant before and after screenshots by uploading them here. Additionally, demo videos can be highly beneficial in demonstrating the process.

amityadav0 and others added 5 commits June 17, 2024 04:38
@amityadav0
[Bug]: Fix calculate discount and add more tests (#570)
62d5ec8 
* add calculate discount test and bug fix

* get asset by denom
@cosmic-vagabond
ci: use post-upgrade-snapshot-generator (#571)
3eec461 
* ci: use post-upgrade-snapshot-generator

* ci: update delete snapshot CI to use post upgrade snapshot gen binary
@amityadav0
update checksame position
71f9c72
@amityadav0
update tests
a556b77
@amityadav0
Merge branch 'develop' into perp
8914ee7
@cosmic-vagabond cosmic-vagabond merged commit 79b1df7 into develop Jun 19, 2024
1 of 2 checks passed
@cosmic-vagabond cosmic-vagabond deleted the perp branch June 19, 2024 11:56
@cosmic-vagabond cosmic-vagabond restored the perp branch June 19, 2024 19:13
@cosmic-vagabond cosmic-vagabond mentioned this pull request Jun 19, 2024
Merged
cosmic-vagabond added a commit that referenced this pull request Jun 19, 2024
@amityadav0 @cosmic-vagabond
[Perpetual]: Update checksameassetposition function (#576)
b7bb704 
* [Bug]: Fix calculate discount and add more tests (#570)

* add calculate discount test and bug fix

* get asset by denom

* ci: use post-upgrade-snapshot-generator (#571)

* ci: use post-upgrade-snapshot-generator

* ci: update delete snapshot CI to use post upgrade snapshot gen binary

* update checksame position

* update tests

* add comment

---------

Co-authored-by: Cosmic Vagabond <[email protected]>
@cosmic-vagabond cosmic-vagabond mentioned this pull request Jun 19, 2024
Merged
cosmic-vagabond added a commit that referenced this pull request Jun 19, 2024
@cosmic-vagabond @amityadav0
@jelysn @Wgil
Lev totoal (#599)
84cf732 
* [Perpetual]: Update checksameassetposition function (#576)

* [Bug]: Fix calculate discount and add more tests (#570)

* add calculate discount test and bug fix

* get asset by denom

* ci: use post-upgrade-snapshot-generator (#571)

* ci: use post-upgrade-snapshot-generator

* ci: update delete snapshot CI to use post upgrade snapshot gen binary

* update checksame position

* update tests

* add comment

---------

Co-authored-by: Cosmic Vagabond <[email protected]>

* ci: clean up upgrade handler (#573)

* [Bug]: Fix calculate discount and add more tests (#570)

* add calculate discount test and bug fix

* get asset by denom

* ci: use post-upgrade-snapshot-generator (#571)

* ci: use post-upgrade-snapshot-generator

* ci: update delete snapshot CI to use post upgrade snapshot gen binary

* ci: clean up upgrade handler

* ci: use latest post upgrade snapshot gen version

* ci: update post upgrade snapshot gen version

* ci: cache snapshot

* ci: use latest version of snapshot gen

* ci: trigger software upgrade test and unit tests for develop, devnet and main branches

---------

Co-authored-by: Amit Yadav <[email protected]>

* Leveragelp rewards claim fix (#577)

* fix leveragelp rewards query and claim fix

* incremenet version

---------

Co-authored-by: Warao <[email protected]>

* Halborn finding fixes (#572)

* [Bug]: Fix calculate discount and add more tests (#570)

* add calculate discount test and bug fix

* get asset by denom

* ci: use post-upgrade-snapshot-generator (#571)

* ci: use post-upgrade-snapshot-generator

* ci: update delete snapshot CI to use post upgrade snapshot gen binary

* halborn finding fixes

* fix masterchef external incentive add

* resolve tests

---------

Co-authored-by: Amit Yadav <[email protected]>
Co-authored-by: Cosmic Vagabond <[email protected]>

* add total leveragelp position query

* handle logic

* fix

* decimal fix

* remove realtime

* update

* reduce args

* update

* changes

* delete file

* update

---------

Co-authored-by: Amit Yadav <[email protected]>
Co-authored-by: jelysn <[email protected]>
Co-authored-by: Warao <[email protected]>
cosmic-vagabond added a commit that referenced this pull request Jun 19, 2024
@cosmic-vagabond @amityadav0
@jelysn @Wgil
Lev totoal (#599)
0abb916 
* [Perpetual]: Update checksameassetposition function (#576)

* [Bug]: Fix calculate discount and add more tests (#570)

* add calculate discount test and bug fix

* get asset by denom

* ci: use post-upgrade-snapshot-generator (#571)

* ci: use post-upgrade-snapshot-generator

* ci: update delete snapshot CI to use post upgrade snapshot gen binary

* update checksame position

* update tests

* add comment

---------

Co-authored-by: Cosmic Vagabond <[email protected]>

* ci: clean up upgrade handler (#573)

* [Bug]: Fix calculate discount and add more tests (#570)

* add calculate discount test and bug fix

* get asset by denom

* ci: use post-upgrade-snapshot-generator (#571)

* ci: use post-upgrade-snapshot-generator

* ci: update delete snapshot CI to use post upgrade snapshot gen binary

* ci: clean up upgrade handler

* ci: use latest post upgrade snapshot gen version

* ci: update post upgrade snapshot gen version

* ci: cache snapshot

* ci: use latest version of snapshot gen

* ci: trigger software upgrade test and unit tests for develop, devnet and main branches

---------

Co-authored-by: Amit Yadav <[email protected]>

* Leveragelp rewards claim fix (#577)

* fix leveragelp rewards query and claim fix

* incremenet version

---------

Co-authored-by: Warao <[email protected]>

* Halborn finding fixes (#572)

* [Bug]: Fix calculate discount and add more tests (#570)

* add calculate discount test and bug fix

* get asset by denom

* ci: use post-upgrade-snapshot-generator (#571)

* ci: use post-upgrade-snapshot-generator

* ci: update delete snapshot CI to use post upgrade snapshot gen binary

* halborn finding fixes

* fix masterchef external incentive add

* resolve tests

---------

Co-authored-by: Amit Yadav <[email protected]>
Co-authored-by: Cosmic Vagabond <[email protected]>

* add total leveragelp position query

* handle logic

* fix

* decimal fix

* remove realtime

* update

* reduce args

* update

* changes

* delete file

* update

---------

Co-authored-by: Amit Yadav <[email protected]>
Co-authored-by: jelysn <[email protected]>
Co-authored-by: Warao <[email protected]>
cosmic-vagabond added a commit that referenced this pull request Jun 19, 2024
@cosmic-vagabond @amityadav0
@jelysn @Wgil
Lev totoal (#599)
2cc913f 
* [Perpetual]: Update checksameassetposition function (#576)

* [Bug]: Fix calculate discount and add more tests (#570)

* add calculate discount test and bug fix

* get asset by denom

* ci: use post-upgrade-snapshot-generator (#571)

* ci: use post-upgrade-snapshot-generator

* ci: update delete snapshot CI to use post upgrade snapshot gen binary

* update checksame position

* update tests

* add comment

---------

Co-authored-by: Cosmic Vagabond <[email protected]>

* ci: clean up upgrade handler (#573)

* [Bug]: Fix calculate discount and add more tests (#570)

* add calculate discount test and bug fix

* get asset by denom

* ci: use post-upgrade-snapshot-generator (#571)

* ci: use post-upgrade-snapshot-generator

* ci: update delete snapshot CI to use post upgrade snapshot gen binary

* ci: clean up upgrade handler

* ci: use latest post upgrade snapshot gen version

* ci: update post upgrade snapshot gen version

* ci: cache snapshot

* ci: use latest version of snapshot gen

* ci: trigger software upgrade test and unit tests for develop, devnet and main branches

---------

Co-authored-by: Amit Yadav <[email protected]>

* Leveragelp rewards claim fix (#577)

* fix leveragelp rewards query and claim fix

* incremenet version

---------

Co-authored-by: Warao <[email protected]>

* Halborn finding fixes (#572)

* [Bug]: Fix calculate discount and add more tests (#570)

* add calculate discount test and bug fix

* get asset by denom

* ci: use post-upgrade-snapshot-generator (#571)

* ci: use post-upgrade-snapshot-generator

* ci: update delete snapshot CI to use post upgrade snapshot gen binary

* halborn finding fixes

* fix masterchef external incentive add

* resolve tests

---------

Co-authored-by: Amit Yadav <[email protected]>
Co-authored-by: Cosmic Vagabond <[email protected]>

* add total leveragelp position query

* handle logic

* fix

* decimal fix

* remove realtime

* update

* reduce args

* update

* changes

* delete file

* update

---------

Co-authored-by: Amit Yadav <[email protected]>
Co-authored-by: jelysn <[email protected]>
Co-authored-by: Warao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosmic-vagabond cosmic-vagabond cosmic-vagabond approved these changes

@jelysn jelysn Awaiting requested review from jelysn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amityadav0 @cosmic-vagabond