Max leverage #1093
Merged
Max leverage #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use pool's leverageMax for proxy leverage calculation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1093 +/- ##
==========================================
+ Coverage 45.06% 45.08% +0.01%
==========================================
Files 964 967 +3
Lines 36943 37017 +74
==========================================
+ Hits 16649 16688 +39
- Misses 18989 19023 +34
- Partials 1305 1306 +1 |
amityadav0
reviewed
Jan 3, 2025
| (cosmos_proto.scalar) = "cosmos.Dec", | ||
| (gogoproto.customtype) = "cosmossdk.io/math.LegacyDec", | ||
| (gogoproto.nullable) = false | ||
| ]; |
There was a problem hiding this comment.
need to use legacyPool structure and migrate old pool structure
|
could you please add migration script for leveragelp pools as well ? |
amityadav0
approved these changes
Jan 6, 2025
| "github.com/elys-network/elys/x/leveragelp/types" | ||
| ) | ||
|
|
||
| // Update params through gov proposal |
There was a problem hiding this comment.
Suggested change
| // Update params through gov proposal | |
| // Update max leverage for a pool through gov proposal |
| "github.com/elys-network/elys/x/perpetual/types" | ||
| ) | ||
|
|
||
| // Update params through gov proposal |
There was a problem hiding this comment.
Suggested change
| // Update params through gov proposal | |
| // Update max leverage for a pool through gov proposal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description