Merge branch 'develop' into lev

elys-network · Jun 26, 2024 · ece8bef · ece8bef
2 parents 77accb8 + 2191fb3
commit ece8bef
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 2 deletions.
diff --git a/.github/workflows/delete-branch-snapshot.yml b/.github/workflows/delete-branch-snapshot.yml
@@ -12,7 +12,7 @@ jobs:
     steps:
       - name: Retrieve post upgrade snapshot generator binary
         run: |
-          POST_UPGRADE_SNAPSHOT_GENERATOR_VERSION=v0.2.2
+          POST_UPGRADE_SNAPSHOT_GENERATOR_VERSION=v0.2.5
           DOWNLOAD_URL=https://github.com/elys-network/post-upgrade-snapshot-generator/releases/download/${POST_UPGRADE_SNAPSHOT_GENERATOR_VERSION}/post-upgrade-snapshot-generator-${POST_UPGRADE_SNAPSHOT_GENERATOR_VERSION}-linux-amd64
           POST_UPGRADE_SNAPSHOT_GENERATOR_PATH=/tmp/post-upgrade-snapshot-generator-${POST_UPGRADE_SNAPSHOT_GENERATOR_VERSION}
           curl -L $DOWNLOAD_URL -o $POST_UPGRADE_SNAPSHOT_GENERATOR_PATH && chmod +x $POST_UPGRADE_SNAPSHOT_GENERATOR_PATH

diff --git a/.github/workflows/software-upgrade-test.yml b/.github/workflows/software-upgrade-test.yml
@@ -40,7 +40,7 @@ jobs:
 
       - name: Retrieve post upgrade snapshot generator binary
         run: |
-          POST_UPGRADE_SNAPSHOT_GENERATOR_VERSION=v0.2.2
+          POST_UPGRADE_SNAPSHOT_GENERATOR_VERSION=v0.2.5
           DOWNLOAD_URL=https://github.com/elys-network/post-upgrade-snapshot-generator/releases/download/${POST_UPGRADE_SNAPSHOT_GENERATOR_VERSION}/post-upgrade-snapshot-generator-${POST_UPGRADE_SNAPSHOT_GENERATOR_VERSION}-linux-amd64
           POST_UPGRADE_SNAPSHOT_GENERATOR_PATH=/tmp/post-upgrade-snapshot-generator-${POST_UPGRADE_SNAPSHOT_GENERATOR_VERSION}
           curl -L $DOWNLOAD_URL -o $POST_UPGRADE_SNAPSHOT_GENERATOR_PATH && chmod +x $POST_UPGRADE_SNAPSHOT_GENERATOR_PATH

diff --git a/x/stablestake/keeper/debt.go b/x/stablestake/keeper/debt.go
@@ -3,6 +3,7 @@ package keeper
 import (
 	"github.com/cosmos/cosmos-sdk/store/prefix"
 	sdk "github.com/cosmos/cosmos-sdk/types"
+	authtypes "github.com/cosmos/cosmos-sdk/x/auth/types"
 	"github.com/elys-network/elys/x/stablestake/types"
 )
 
@@ -81,6 +82,18 @@ func (k Keeper) Borrow(ctx sdk.Context, addr sdk.AccAddress, amount sdk.Coin) er
 	if depositDenom != amount.Denom {
 		return types.ErrInvalidBorrowDenom
 	}
+
+	// For security reasons, we should avoid borrowing more than 90% in total to the stablestake pool.
+	moduleAddr := authtypes.NewModuleAddress(types.ModuleName)
+	params := k.GetParams(ctx)
+	balance := k.bk.GetBalance(ctx, moduleAddr, depositDenom)
+
+	borrowed := params.TotalValue.Sub(balance.Amount).ToLegacyDec().Add(amount.Amount.ToLegacyDec())
+	maxAllowed := params.TotalValue.ToLegacyDec().Mul(sdk.NewDec(9)).Quo(sdk.NewDec(10))
+	if borrowed.GT(maxAllowed) {
+		return types.ErrMaxBorrowAmount
+	}
+
 	debt := k.UpdateInterestStackedByAddress(ctx, addr)
 	debt.Borrowed = debt.Borrowed.Add(amount.Amount)
 	k.SetDebt(ctx, debt)

diff --git a/x/stablestake/types/errors.go b/x/stablestake/types/errors.go
@@ -12,4 +12,5 @@ var (
 	ErrInvalidBorrowDenom   = errorsmod.Register(ModuleName, 2, "invalid borrow denom")
 	ErrRedemptionRateIsZero = errorsmod.Register(ModuleName, 3, "redemption rate is zero")
 	ErrNegativeBorrowed     = errorsmod.Register(ModuleName, 4, "negative borrowed amount")
+	ErrMaxBorrowAmount      = errorsmod.Register(ModuleName, 5, "cannot borrow more than 90% of total stablestake pool.")
 )