Skip to content

Commit

Permalink
Bump staticcheck to 0.4.5, and update CONTRIBUTING.md.
Browse files Browse the repository at this point in the history
Also add comments in both CONTRIBUTING.md and .github/workflows/ci.yml about
keeping the versions in sync.
  • Loading branch information
xiaq committed Aug 21, 2023
1 parent 1b10161 commit efae7e0
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,8 @@ jobs:
run: |
go install golang.org/x/tools/cmd/stringer@latest
go install golang.org/x/tools/cmd/goimports@latest
go install honnef.co/go/tools/cmd/[email protected]
# Keep the versions of staticcheck and codespell in sync with CONTRIBUTING.md
go install honnef.co/go/tools/cmd/[email protected]
pip install --user codespell==2.2.5
- name: Run checks
run: make all-checks
Expand Down
6 changes: 4 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -194,10 +194,12 @@ used.

The checks depend on some external programs, which can be installed as follows:

<!-- Keep the versions of staticcheck and codespell in sync with .github/workflows/ci.yml -->

```sh
go install golang.org/x/tools/cmd/goimports@latest
go install honnef.co/go/tools/cmd/[email protected].2
pip install --user codespell==2.2.1
go install honnef.co/go/tools/cmd/[email protected].5
pip install --user codespell==2.2.5
```

## Licensing
Expand Down

0 comments on commit efae7e0

Please sign in to comment.