-
-
Notifications
You must be signed in to change notification settings - Fork 303
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Bump staticcheck to 0.4.5, and update CONTRIBUTING.md.
Also add comments in both CONTRIBUTING.md and .github/workflows/ci.yml about keeping the versions in sync.
- Loading branch information
Showing
2 changed files
with
6 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -118,7 +118,8 @@ jobs: | |
run: | | ||
go install golang.org/x/tools/cmd/stringer@latest | ||
go install golang.org/x/tools/cmd/goimports@latest | ||
go install honnef.co/go/tools/cmd/[email protected] | ||
# Keep the versions of staticcheck and codespell in sync with CONTRIBUTING.md | ||
go install honnef.co/go/tools/cmd/[email protected] | ||
pip install --user codespell==2.2.5 | ||
- name: Run checks | ||
run: make all-checks | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -194,10 +194,12 @@ used. | |
|
||
The checks depend on some external programs, which can be installed as follows: | ||
|
||
<!-- Keep the versions of staticcheck and codespell in sync with .github/workflows/ci.yml --> | ||
|
||
```sh | ||
go install golang.org/x/tools/cmd/goimports@latest | ||
go install honnef.co/go/tools/cmd/[email protected].2 | ||
pip install --user codespell==2.2.1 | ||
go install honnef.co/go/tools/cmd/[email protected].5 | ||
pip install --user codespell==2.2.5 | ||
``` | ||
|
||
## Licensing | ||
|