Remove cruft from configure script #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliotgoodrich
force-pushed
the
remove-cruft-configure
branch
5 times, most recently
from
1fdd7ed to
a8b8625
Compare
Continue the effort to remove things from the configure script that
should be handled by default in the plugins. In this case it is,
1. `phony` supports extracting `orderOnlyDeps` from the input so we
can depend on formatted files
2. all plugins now support passing `orderOnlyDeps` when creating
rules, which we use to replace our `inject` function
3. the `biome` plugin takes a `configPath` so we no longer need to
wrap the function and inject it ourselves
Upgrade to the latest biome as part of this, which also requires fixing
a few small linting errors.
elliotgoodrich
force-pushed
the
remove-cruft-configure
branch
from
a8b8625 to
ba25c0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue the effort to remove things from the configure script that should be handled by default in the plugins. In this case it is,
phonysupports extractingorderOnlyDepsfrom the input so we can depend on formatted filesorderOnlyDepswhen creating rules, which we use to replace ourinjectfunctionbiomeplugin takes aconfigPathso we no longer need to wrap the function and inject it ourselvesUpgrade to the latest biome as part of this, which also requires fixing a few small linting errors.