All phony to take an array of targets
#9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `phony` rule can actually take multiple targets and not just one. My initial reading of the documentation missed this. Double bump the version as 0.8.4 had a trailing space for `phony` rules with no inputs. This isn't an issue for `ninja`, but does not match our other rules.
elliotgoodrich
force-pushed
the
improve-phony
branch
from
b36e898 to
f8393a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
phonyrule can actually take multiple targets and not just one. My initial reading of the documentation missed this.Double bump the version as 0.8.4 had a trailing space for
phonyruleswith no inputs. This isn't an issue for
ninja, but does not match ourother rules.