Move tests into individual packages #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests were originally put into a separate package and then link in all of the plugin packages to check that I had the correct entry points set up in `package.json`. As we are self-hosted it should be obvious when this breaks now. The downside of external packages means that if we break a plugin and it fails to build, then we are unable to run the tests for any plugin at all as it would be a dependency. It also means less chance of parallelization because every test depends on every plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests were originally put into a separate package and then link in all of the plugin packages to check that I had the correct entry points set up in
package.json. As we are self-hosted it should be obvious when this breaks now.The downside of external packages means that if we break a plugin and it fails to build, then we are unable to run the tests for any plugin at all as it would be a dependency. It also means less chance of parallelization because every test depends on every plugin.