Use the new linting rule #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the new linting rule and the fact that it injects a `validations` step into any dependent build edges to avoid manually passing a `validations` property. We also do not need the `cwd` property (for a long time!) and the order-only dependencies aren't needed as we install `biome` at the top level instead of per-package and it's installed before `configure.mjs` is ever ran.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new linting rule and the fact that it injects a
validationsstep into any dependent build edges to avoid manually passing avalidationsproperty.We also do not need the
cwdproperty (for a long time!) and the order-only dependencies aren't needed as we installbiomeat the top level instead of per-package and it's installed beforeconfigure.mjsis ever ran.