New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation warning in 1.17/1.18 + update deps #134

Open

tmjoen wants to merge 3 commits into elixirs:main from tmjoen:main

tmjoen commented Dec 21, 2024

Fixed this warning:

==> base62
Compiling 1 file (.ex)
    warning: single-quoted strings represent charlists. Use ~c"" if you indeed want a charlist or use "" instead.
    You may run "mix format --migrate" to fix this warning automatically.
    │
  2 │   use CustomBase, '0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz'
    │                   ~
    │
    └─ lib/base62.ex:2:19

Also updated test/dev deps to latest version. Bumped required Elixir version to 1.12 (which is still ancient :)) to support newer stream_data dep.

tmjoen added 2 commits

December 21, 2024 10:04


          Update deps

1a987ef


          Fix deprecation warning

be50149

Author

tmjoen commented Dec 21, 2024

We should probably update the Github actions as well since I'd assume this PR will fail on 1.11.x


          Remove 1.11, add 1.16, 1.17, 1.18 to CI matrix

dca220b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet