-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KDTrees #206
Conversation
The numbers are really good. For N=1000 on the CPU:
|
GPU, N=1_000_00 (ht @polvalente)
|
What is the dimension of the data you used for benchmarks? Update: I see it's equal to 3, sorry for asking this. |
To add to your question/answer, the dimension should not impact the results, as we don't store the tensors and we only cycle through them. |
lib/scholar/neighbors/kd_tree.ex
Outdated
@doc """ | ||
Builds a KDTree without known min-max bounds. | ||
|
||
If your tensor has a known band (for example, -1 and 1), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the wording they use in one of the papers? I would expect "bounds" and bounded/2
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No paper uses it, the idea is that it would reflect "frequency bands" but I think bound and unbound is more common. It may be a bit confusing because they are not really unbound and more of a question if the bounds are known and reasonable.
💚 💙 💜 💛 ❤️ |
No description provided.