-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added log loss classification metric #199
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
approved these changes
Oct 26, 2023
msluszniak
approved these changes
Oct 26, 2023
msluszniak
reviewed
Oct 26, 2023
josevalim
reviewed
Oct 26, 2023
josevalim
reviewed
Oct 26, 2023
msluszniak
reviewed
Oct 26, 2023
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I based the implementation on sklearn's, with these main differences:
y_true
is always given by its ordered ranking over ally_true
values (in the language ofsklearn
, the class index is always inferred). For example, ify_true = [4, 0, 9, 4, 9]
the indices would be[1, 0, 2, 1, 2]
.y_prob
values to interval(eps, 1-eps)
. That meanslog(0)
can be evaluated to-Inf
which would immediately cause a return ofInf
for the function. I chose to keep this possibility because it immediately signals either that the client got inputs wrong, or that they should retrain their model/forecaster. Plus, I did try clipping to theeps
interval usingNx.Constants.epsilon/2
for the underlying floats in the tensor, and still gotInf
's returned.