added tests for tsvd + bugfixed it

elixir-nx · Nov 1, 2024 · 0cbc4b0 · 0cbc4b0
1 parent 15662fa
commit 0cbc4b0
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 41 deletions.
diff --git a/lib/scholar/decomposition/truncated_svd.ex b/lib/scholar/decomposition/truncated_svd.ex
@@ -174,7 +174,7 @@ defmodule Scholar.Decomposition.TruncatedSVD do
     end
 
     {u, sigma, vt} = randomized_svd(x, key, opts)
-    {_u, vt} = Scholar.Decomposition.Utils.flip_svd(u, vt)
+    {_u, vt} = Scholar.Decomposition.Utils.flip_svd(u, vt, false)
 
     x_transformed = Nx.dot(x, Nx.transpose(vt))
     explained_variance = Nx.variance(x_transformed, axes: [0])

diff --git a/test/scholar/decomposition/truncated_svd_tests.exs b/test/scholar/decomposition/truncated_svd_tests.exs