Add Safetensors.write!/2 for streamed write #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When persisting to a file,
Safetensors.dump/1
callsNx.to_binary/1
on all tensors upfront (and if we need to convert endianness, we create yet another binary), so this can cause a significant memory bump. This PR addsSafetensors.write!/2
that converts and writes tensors directly to the file, one by one.Other than lower memory usage, this can also be much faster. For the example below, it's 5 times faster for me: