Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve docs for Nx.conv/3 #1564

Merged
merged 2 commits into from
Dec 7, 2024
Merged

docs: improve docs for Nx.conv/3 #1564

merged 2 commits into from
Dec 7, 2024

Conversation

polvalente
Copy link
Contributor

No description provided.

@polvalente polvalente self-assigned this Dec 7, 2024
josevalim
josevalim reviewed Dec 7, 2024
View reviewed changes
nx/lib/nx.ex Outdated Show resolved Hide resolved
josevalim
josevalim reviewed Dec 7, 2024
View reviewed changes
nx/lib/nx.ex Show resolved Hide resolved
@polvalente polvalente merged commit cb7fed4 into main Dec 7, 2024
8 checks passed
@polvalente polvalente deleted the pv-docs/improve-conv-docs branch December 7, 2024 22:31
@hunterboerner
Copy link

Assuming SciPy's convolve function is correct then these docs are wrong. To match SciPy's convolution you reverse the kernel, don't apply conjugate , call Nx.conv, then reverse the output. This is being worked on in my fork of NxSignal: https://github.com/hunterboerner/nx_signal/tree/convolutions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

Assignees

@polvalente polvalente

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@polvalente @hunterboerner @josevalim