Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test on stable ordering instead of ref-dependent order #1537

Merged
merged 2 commits into from
Sep 24, 2024
Merged

fix: test on stable ordering instead of ref-dependent order #1537

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63b19d7
fix: test on stable ordering instead of ref-dependent order
polvalente Sep 24, 2024
7b531bb
Update nx/test/nx/defn/tree_test.exs
polvalente Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions nx/test/nx/defn/tree_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
defmodule Nx.Defn.TreeTest do
use ExUnit.Case, async: true
use ExUnit.Case, async: false
polvalente marked this conversation as resolved.
Show resolved Hide resolved

alias Nx.Defn.{Expr, Tree}
doctest Nx.Defn.Tree
Expand Down Expand Up @@ -40,7 +40,9 @@ defmodule Nx.Defn.TreeTest do

test "ignores constants" do
a = Expr.parameter(:root, {:u, 64}, {}, 0)
assert [{_, :parameter}, {_, :add}] = plus_constant(a) |> Tree.scope_ids() |> Enum.sort()

assert [{_, :add}, {_, :parameter}] =
plus_constant(a) |> Tree.scope_ids() |> Enum.sort_by(&elem(&1, 1))
end

defn inside_cond(bool, a, b) do
Expand All @@ -54,8 +56,8 @@ defmodule Nx.Defn.TreeTest do
test "ignores expressions inside cond" do
{bool, cond} = Nx.Defn.jit(&{&1, inside_cond(&1, &2, &3)}).(0, 1, 2)

assert cond |> Tree.scope_ids() |> Enum.sort() ==
[{bool.data.id, :parameter}, {cond.data.id, :cond}]
assert cond |> Tree.scope_ids() |> Enum.sort_by(&elem(&1, 1)) ==
[{cond.data.id, :cond}, {bool.data.id, :parameter}]
end

defn inside_both_cond(bool, a, b) do
Expand Down Expand Up @@ -84,14 +86,14 @@ defmodule Nx.Defn.TreeTest do
b = Expr.parameter(:root, {:u, 64}, {}, 2)

assert [
{_, :parameter},
{_, :parameter},
{_, :parameter},
{_, :add},
{_, :cond},
{_, :cond},
{_, :multiply}
] = inside_both_cond(bool, a, b) |> Tree.scope_ids() |> Enum.sort()
{_, :multiply},
{_, :parameter},
{_, :parameter},
{_, :parameter}
] = inside_both_cond(bool, a, b) |> Tree.scope_ids() |> Enum.sort_by(&elem(&1, 1))
end
end

Expand Down
Loading