Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EXLA suite is currently failing:
Erlang does not allow us to pass bitstrings to C, only binaries (the number must be divisible by 8). So I am currently padding it, which should be fine, because all XLA cares is about a pointer at the beginning of the data. However, the call still fails. Here is the source that we call into:
https://github.com/openxla/xla/blob/091ef0c6ec9cb48b04d3f764b6c8b549b189d06c/xla/pjrt/pjrt_stream_executor_client.cc#L823