Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly set comparison type attribute on MLIR comparison ops #1502

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Properly set comparison type attribute on MLIR comparison ops #1502

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions exla/lib/exla/mlir/value.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,15 +64,20 @@ defmodule EXLA.MLIR.Value do
%{type: rhs_type} = get_typespec(rhs)

comparison_type =
if Nx.Type.float?(lhs_type) or Nx.Type.float?(rhs_type) do
attr_comparison_type(:totalorder)
else
attr_comparison_type(:notype)
cond do
Nx.Type.complex?(lhs_type) or Nx.Type.complex?(rhs_type) ->
attr_comparison_type(:float)

Nx.Type.float?(lhs_type) or Nx.Type.float?(rhs_type) ->
attr_comparison_type(:float)

true ->
attr_comparison_type(:notype)
end

attributes = [
comparison_direction: attr_comparison_direction(direction),
comparison_type: comparison_type
compare_type: comparison_type
]

result_types = typespecs_to_mlir_types([Typespec.to_type(typespec, {:pred, 8})])
Expand Down Expand Up @@ -929,7 +934,7 @@ defmodule EXLA.MLIR.Value do
defp attr_comparison_direction(value) when value in [:eq, :lt, :le, :gt, :ge, :ne],
do: attr_enum("stablehlo", "comparison_direction", value)

defp attr_comparison_type(value) when value in [:totalorder, :notype],
defp attr_comparison_type(value) when value in [:float, :totalorder, :notype],
do: attr_enum("stablehlo", "comparison_type", value)

defp attr_precision(value) when value in [:default, :high, :highest],
Expand Down
Loading