refactor: remove XlaOp workflow #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Mar 2, 2024
exla/c_src/exla/exla_client.o
Outdated
There was a problem hiding this comment.
Is this file here intentionally? Same below.
There was a problem hiding this comment.
No, this is a stray file from while I was working on the Makefile :)
josevalim
reviewed
Mar 2, 2024
exla/lib/exla/computation.ex
Outdated
| device_id: device_id | ||
| } | ||
| end | ||
|
|
||
| def compile( |
There was a problem hiding this comment.
We should talk about this. :)
josevalim
reviewed
Mar 2, 2024
exla/lib/exla/mlir/region.ex
Outdated
| @@ -1,5 +1,5 @@ | |||
| defmodule EXLA.MLIR.Region do | |||
| @moduledoc false | |||
| @moduledoc "Holds the ref for an MLIR region." | |||
There was a problem hiding this comment.
I think all MLIR modules should be false for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all of the XlaOp workflow
Because I had to touch the Makefile, I also took the opportunity to start speeding recompilations up.