feat: add config for compiler mode #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
polvalente
commented
Feb 20, 2024
polvalente
commented
- feat: add compiler mode config
- feat: add compiler_mode config
exla/lib/exla.ex
Outdated
| @@ -71,6 +71,17 @@ defmodule EXLA do | |||
| * `:highest` - Slowest but most accurate. Performs computations in float32 | |||
| or float64 as applicable | |||
|
|
|||
| * `:compiler_mode` - the mode to use for the compiler. It must be one of: | |||
There was a problem hiding this comment.
One space less indentation :)
| @@ -581,7 +581,7 @@ defmodule EXLA.Defn do | |||
|
|
|||
| inputs_and_shapes = Enum.reverse(reverse_inputs_and_shapes) | |||
|
|
|||
| mode = options[:compiler_mode] || :xla | |||
| mode = options[:compiler_mode] || Application.get_env(:exla, :compiler_mode, :mlir) | |||
There was a problem hiding this comment.
I think having just the config attribute would be fine, but if streamlines a particular use case both are fine.
There was a problem hiding this comment.
It is temporary anyway, so both are fine. :)
josevalim
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.