Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(torchx): more efficient put_slice #1358

Merged
merged 3 commits into from
Nov 9, 2023
Merged

refactor(torchx): more efficient put_slice #1358

merged 3 commits into from
Nov 9, 2023

Conversation

polvalente
Copy link
Contributor

  • wip: torchx put slice
  • fix: return outer ref

@polvalente polvalente self-assigned this Nov 8, 2023
josevalim
josevalim approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. We may be able to simplify slice too!

@polvalente polvalente merged commit 9f74c08 into main Nov 9, 2023
8 checks passed
@polvalente polvalente deleted the pv-feat/torchx-put-slice branch November 9, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

Assignees

@polvalente polvalente

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@polvalente @josevalim