Store Ash bread crumbs in occurrence context #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some frameworks such as Ash provide bread crumbs in their errors. This commit records those breadcrumbs and stores them in the occurrence context.
crbelaus
force-pushed
the
bread-crumbs-in-context
branch
from
76661f0
to
8b72136
Compare
odarriba
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some frameworks such as Ash include breadcrumbs in their errors. This is provided by the fantastic Splode library (details).
This commit updates the ErrorTracker to detect such bread crumbs and include them in the occurrence context. In the future we may want to revisit this and store them in their own field separate from the context.
It is important to note that you don't have to use Ash or Splode to leverage this integration. Breadcrumbs will be automatically extracted from any exception that includes a
bread_crumbsfield.I've discussed this with @zachdaniel and he kindly integrated the breadcrumbs on Ash main for create and change actions.
To test this you can clone the Ash Realworld example project and update the ash dependency to main with
{:ash, github: "ash-project/ash", override: true}. Here is a screenshot of how it looks like: