-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add move_files test #20
Conversation
Reviewer's Guide by SourceryThis pull request adds a comprehensive test suite for the move_files function in the decryption module. The changes include importing the move_files function, creating a new TestMoveFiles class, and adding multiple test cases to ensure the function handles various scenarios correctly, such as moving files, handling empty lists, duplicate file names, and non-existent directories. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @athith-g - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 4 issues found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, minus this one very minor comment.
Adds tests for move_files.
Summary by Sourcery
This pull request introduces a new set of tests for the
move_files
function, ensuring its correct behavior under various scenarios including empty lists, unique files, duplicate file names, and non-existent directories.TestMoveFiles
to verify the functionality of themove_files
function.