-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add decrypt files tests #19
Conversation
Reviewer's Guide by SourceryThis pull request adds tests for the File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @athith-g - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 5 issues found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, one question about the fixtures and 1-2 small nits.
Adds tests for decrypt_files.
Summary by Sourcery
This pull request introduces new tests for the
decrypt_files
function, ensuring its correct behavior with both encrypted and unencrypted files. The tests include setup for key pairs and file encryption, enhancing the test coverage for the decryption functionality.decrypt_files
function, including fixtures for key pairs, encrypted files, and unencrypted files.decrypt_files
correctly decrypts encrypted files in-place and does not throw exceptions for unencrypted files.