Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add decrypt files tests #19

Merged
merged 13 commits into from
Jul 17, 2024
Merged

test: add decrypt files tests #19

merged 13 commits into from
Jul 17, 2024

Conversation

athith-g
Copy link
Collaborator

@athith-g athith-g commented Jul 8, 2024

Adds tests for decrypt_files.

Summary by Sourcery

This pull request introduces new tests for the decrypt_files function, ensuring its correct behavior with both encrypted and unencrypted files. The tests include setup for key pairs and file encryption, enhancing the test coverage for the decryption functionality.

  • Tests:
    • Added comprehensive tests for the decrypt_files function, including fixtures for key pairs, encrypted files, and unencrypted files.
    • Ensured that decrypt_files correctly decrypts encrypted files in-place and does not throw exceptions for unencrypted files.

Copy link

sourcery-ai bot commented Jul 8, 2024

Reviewer's Guide by Sourcery

This pull request adds tests for the decrypt_files function in the crypt4gh_middleware module. The changes include the addition of a new test class TestDecryptFiles with several fixtures and a parameterized test method to ensure the correct functionality of the decrypt_files function. Additionally, minor modifications were made to the existing TestGetPrivateKeys class to correct the key retrieval method.

File-Level Changes

Files Changes
tests/decryption/test_decrypt.py Introduced a new test class TestDecryptFiles with necessary fixtures and a parameterized test method to validate the decrypt_files function. Also, corrected the key retrieval method in the existing TestGetPrivateKeys class.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @athith-g - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟡 Testing: 5 issues found
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

tests/decryption/test_decrypt.py Outdated Show resolved Hide resolved
tests/decryption/test_decrypt.py Outdated Show resolved Hide resolved
tests/decryption/test_decrypt.py Outdated Show resolved Hide resolved
tests/decryption/test_decrypt.py Outdated Show resolved Hide resolved
tests/decryption/test_decrypt.py Show resolved Hide resolved
tests/decryption/test_decrypt.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@jvkersch jvkersch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, one question about the fixtures and 1-2 small nits.

tests/decryption/test_decrypt.py Outdated Show resolved Hide resolved
tests/decryption/test_decrypt.py Show resolved Hide resolved
tests/decryption/test_decrypt.py Outdated Show resolved Hide resolved
@athith-g athith-g requested a review from jvkersch July 15, 2024 17:15
@athith-g athith-g merged commit 8194953 into main Jul 17, 2024
1 check passed
@athith-g athith-g deleted the add_decrypt_files_tests branch July 17, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants