Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: expand CI workflow #15

Merged
merged 13 commits into from
Jul 24, 2024
Merged

ci: expand CI workflow #15

merged 13 commits into from
Jul 24, 2024

Conversation

athith-g
Copy link
Collaborator

@athith-g athith-g commented Jun 25, 2024

Added linting to middleware files and mypy to the worflow. Also added the outputs file to gitignore (this is the file where the test outputs are placed).

Summary by Sourcery

Expanded the CI workflow to include linting and type checking for middleware files.

  • CI:
    • Added linting for middleware files using pylint and ruff.
    • Integrated mypy type checking for middleware files.

Copy link

sourcery-ai bot commented Jun 25, 2024

Reviewer's Guide by Sourcery

This pull request expands the CI workflow by adding linting for middleware files using pylint and ruff, and introduces type checking for middleware files using mypy.

File-Level Changes

Files Changes
.github/workflows/checks.yaml Expanded CI workflow to include linting and type checking for middleware files.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @athith-g - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

.github/workflows/checks.yaml Outdated Show resolved Hide resolved
@uniqueg uniqueg changed the title ci: expand ci workflow ci: expand CI workflow Jul 1, 2024
requirements_dev.txt Outdated Show resolved Hide resolved
@athith-g athith-g mentioned this pull request Jul 1, 2024
@athith-g athith-g requested a review from uniqueg July 5, 2024 17:06
@athith-g athith-g merged commit 164f8ad into main Jul 24, 2024
1 check passed
@athith-g athith-g deleted the expand_ci branch July 24, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants