Fix derive_name_locale/2

elixir-cldr · Dec 7, 2024 · eb6b0bb · eb6b0bb
1 parent fcfd445
commit eb6b0bb
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,13 @@
 # Changelog
 
+## Cldr Person Names v0.2.1
+
+This is the changelog for `ex_cldr_person_names` v0.2.1 released on December 8th, 2024.  For older changelogs please consult the release tag on [GitHub](https://github.com/elixir-cldr/cldr_person_names/tags)
+
+### Bug Fixes
+
+* Fixes `Cldr.PersonName.Formatter.derive_name_locale/2`. Thanks to @peaceful-james for the PR. Closes #1.
+
 ## Cldr Person Names v0.2.0
 
 This is the changelog for `ex_cldr_person_names` v0.2.0 released on April 24th, 2023.  For older changelogs please consult the release tag on [GitHub](https://github.com/elixir-cldr/cldr_person_names/tags)

diff --git a/lib/cldr/person_name/formatter.ex b/lib/cldr/person_name/formatter.ex
@@ -722,12 +722,10 @@ defmodule Cldr.PersonName.Formatter do
 
   def derive_name_locale(%{locale: nil} = name, formatting_locale) do
     name_script = dominant_script(name)
-    name_locale = find_likely_locale_for_script(name_script, formatting_locale.backend)
 
-    if name_locale do
-      {:ok, name_locale}
-    else
-      {:error, "No locale resolved for script #{inspect(name_script)}"}
+    case find_likely_locale_for_script(name_script, formatting_locale.backend) do
+      {:ok, name_locale} when not is_nil(name_locale) -> {:ok, name_locale}
+      _ -> {:error, "No locale resolved for script #{inspect(name_script)}"}
     end
   end
 

diff --git a/mix.exs b/mix.exs
@@ -1,7 +1,7 @@
 defmodule Cldr.PersonName.Mixfile do
   use Mix.Project
 
-  @version "0.2.0"
+  @version "0.2.1"
 
   def project do
     [