Show an indicator icon for each active connection

[meisenzahl]

Closes #200

[meisenzahl]

Due to missing hardware I can't test all possible configurations.

[jeremypw]

A couple of coding comments. I try testing this with some faked connections.

[jeremypw]

You have not implemented a handler for "Network.State.DISCONNECTED_WIRED" so the wired indicator does not disappear if you unplug the cable and you still have a wireless network connection.

[jeremypw]

Another issue that required some thought - there is only one tooltip and only one Network.State at any moment so you get, for example a message about the wireless connection when hovering over the wire connection icon. It will require some refactoring to get a tooltip relevant to the icon being hovered.

[meisenzahl]

@jeremypw thanks for your detailed review. Could you please take a look at my changes again? 😅️

[jeremypw]

Trying latest version ...

[jeremypw]

There is still a problem detecting disconnection/disabling wireless and wired networks (until restart the session).

If you start with a wireless connection and a wired connection (plugged in) then you get two icons as expected.
Unplugging the wired connection does not remove the wired icon
Switching off the wireless connection with the popover does not remove the wireless icon
Switching off the wired connection does remove the wired icon.

[jeremypw]

You probably need to add tooltips to the images themselves rather than the overall display widget.

[danirabbit]

Gonna move this to "draft" since there's been no movement since April. Please feel free to reopen when this is ready for review again :)