Added a Gtk.ScrollingWindow to the Release notes dialog (issue #2033) #2251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short summary
This aims to fix #2033
Added a
Gtk.ScrolledWindowinside the release notes window. This has a fixed size that will show a scrollbar if the notes go beyond the expected size and avoid extra large release notes windows.Tests
I managed to reproduce this on the Colorful app
Before:
After:
I tested other apps with different release notes layouts, and they worked ok, although none of them had the extremely long window height that Colorful had.
Other notes
The
Gtk.ScrolledWindowhas a bit hardcoded part onwidth_requestandheight_requestset400x320. Not sure if this could be a good solution, given my not broad knowledge on GTK4. If anyone has a better idea here, please, let me know to amend this PR.