Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed quality dimensions for custom names #741

Merged
merged 1 commit into from
Aug 1, 2024
Merged

fixed quality dimensions for custom names #741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions macros/edr/dbt_artifacts/upload_dbt_tests.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
('error_if', 'string'),
('test_params', 'long_string'),
('test_namespace', 'string'),
('test_original_name', 'string'),
('tags', 'long_string'),
('model_tags', 'long_string'),
('model_owners', 'long_string'),
Expand All @@ -48,9 +49,10 @@

{% set test_metadata = elementary.safe_get_with_default(node_dict, 'test_metadata', {}) %}
{% set test_namespace = test_metadata.get('namespace') %}
{% set test_original_name = test_metadata.get('name') %}
{% set test_short_name = elementary.get_test_short_name(node_dict, test_metadata) %}

{% set default_description = elementary.get_default_description(test_short_name, test_namespace) %}
{% set default_description = elementary.get_default_description(test_original_name, test_namespace) %}

{% set config_meta_dict = elementary.safe_get_with_default(config_dict, 'meta', {}) %}
{% set meta_dict = {} %}
Expand Down Expand Up @@ -148,6 +150,7 @@
'error_if': config_dict.get('error_if'),
'test_params': test_kwargs,
'test_namespace': test_namespace,
'test_original_name': test_original_name,
'tags': elementary.filter_none_and_sort(tags),
'model_tags': elementary.filter_none_and_sort(test_models_tags),
'model_owners': elementary.filter_none_and_sort(test_models_owners),
Expand All @@ -165,7 +168,7 @@
'compiled_code': elementary.get_compiled_code(node_dict),
'path': node_dict.get('path'),
'generated_at': elementary.datetime_now_utc_as_string(),
'quality_dimension': meta_dict.get('quality_dimension') or elementary.get_quality_dimension(test_short_name, test_namespace)
'quality_dimension': meta_dict.get('quality_dimension') or elementary.get_quality_dimension(test_original_name, test_namespace)
}%}
{% do flatten_test_metadata_dict.update({"metadata_hash": elementary.get_artifact_metadata_hash(flatten_test_metadata_dict)}) %}
{{ return(flatten_test_metadata_dict) }}
Expand Down Expand Up @@ -217,19 +220,19 @@
{% endmacro %}


{% macro get_default_description(short_name, test_namespace = none) %}
{% macro get_default_description(test_original_name, test_namespace = none) %}
{% set description = none %}
{% set common_test_config = elementary.get_common_test_config_by_namespace_and_name(test_namespace, short_name) %}
{% set common_test_config = elementary.get_common_test_config_by_namespace_and_name(test_namespace, test_original_name) %}
{% if common_test_config %}
{% set description = common_test_config.get("description") %}
{% endif %}
{% do return(description) %}
{% endmacro %}


{% macro get_quality_dimension(short_name, test_namespace = none) %}
{% macro get_quality_dimension(test_original_name, test_namespace = none) %}
{% set quality_dimension = none %}
{% set common_test_config = elementary.get_common_test_config_by_namespace_and_name(test_namespace, short_name) %}
{% set common_test_config = elementary.get_common_test_config_by_namespace_and_name(test_namespace, test_original_name) %}
{% if common_test_config %}
{% set quality_dimension = common_test_config.get("quality_dimension") %}
{% endif %}
Expand Down
2 changes: 1 addition & 1 deletion macros/utils/common_test_configs.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{% macro get_common_test_config(flattened_test) %}
{% set test_name = flattened_test["short_name"] %}
{% set test_name = flattened_test["test_original_name"] %}
{% set test_namespace = flattened_test["test_namespace"] %}
{% do return(elementary.get_common_test_config_by_namespace_and_name(test_namespace, test_name)) %}
{% endmacro %}
Expand Down
Loading