Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safely accessing 'is_delta'. #499

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Safely accessing 'is_delta'. #499

merged 2 commits into from
Aug 21, 2023

Conversation

elongl
Copy link
Member

@elongl elongl commented Aug 21, 2023

No description provided.

@linear
Copy link

linear bot commented Aug 21, 2023

ELE-1607 Safely accessing `is_delta`

is_delta contains an assert that crashes the dbt run.

Add a check to ensure the assert would pass.

@github-actions
Copy link
Contributor

👋 @elongl
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in the elementary repository.

@elongl elongl merged commit ae496f7 into master Aug 21, 2023
15 of 16 checks passed
@elongl elongl deleted the ele-1607-safely-accessing-is_delta branch August 21, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek1weiss ofek1weiss ofek1weiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elongl @ofek1weiss