Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes quotes in column anomalies tests #466

Merged
merged 4 commits into from
May 28, 2024

Conversation

Arun-kc
Copy link
Contributor

@Arun-kc Arun-kc commented Aug 7, 2023

Description

Resolves bug #913

Removes quotes from column names before comparison in the macro get_column_obj_and_monitors

@noaKurman
Copy link
Contributor

Hey @Arun-kc !
Thanks for this contribution :) I want to run the test on this PR, can you update your master and merge it again? Then you can contact me and I'll run the tests

@Arun-kc
Copy link
Contributor Author

Arun-kc commented Sep 30, 2023

Hey @Arun-kc ! Thanks for this contribution :) I want to run the test on this PR, can you update your master and merge it again? Then you can contact me and I'll run the tests

Hi @noaKurman, happy to help! I have updated the master and have merged it. Please take a look at it.

@haritamar
Copy link
Collaborator

Sorry for the delay @Arun-kc , this PR looks good!
I'm merging it
(Failing tests seem unrelated to the test, we're fixing them separately)

@haritamar haritamar merged commit 9e08b47 into elementary-data:master May 28, 2024
13 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ELE-996] Defining quote: true on columns fails the column anomalies tests
4 participants