Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ele 1453 implement metrics collection #447
Ele 1453 implement metrics collection #447
Changes from 13 commits
c69e0aa
9f1702c
3b89bc7
ef355b2
088c075
f819420
9e9ce64
6e4d3cf
3542290
bdf3f13
fe44a61
7ba7616
915ca16
456b849
efafcf7
2bf4de9
7e2f82c
7bb2bdb
57b0426
3cd6bb5
2e3d04f
4f7b75e
22067b2
ce276b8
2b30eaa
bd3d1fb
1b9aa0a
2925c0d
acc8bae
a35e04a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can it somehow affect existing tests that we're writing to
data_monitoring_metrics
?I think it should be fine but just verifying
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those metrics aren't being used in the tests for now because they don't have metric properties.