Add MSC3861 config options admin_token_path and client_secret_path #18004
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two config options
admin_token_path
andclient_secret_path
to the experimental config underexperimental_features.msc3861
. Also includes tests.I tried to be a good citizen here by following
attrs
conventions and not rewriting the corresponding non-path variants in the class, but instead adding methods to retrieve the value.It is noteworthy that in this patch each access to the client secret or the admin token will re-read it from file. In the current state a ConfigError will be raised at runtime when the file can not be read anymore. You might prefer another form of error handling than the current behavior.
A big pro of directly using the secret contents from file is that it enables secret rotation without having to restart Synapse.
Pull Request Checklist
EventStore
toEventWorkerStore
.".code blocks
.(run the linters)